[PATCH] D31695: Windows asan_device_setup.bat port of linux shell script

[Steven Winston via Phabricator via llvm-commits]

gpx1000 added a comment.

In https://reviews.llvm.org/D31695#824877, @eugenis wrote:

> In https://reviews.llvm.org/D31695#824674, @gpx1000 wrote:
>
> > In https://reviews.llvm.org/D31695#824667, @eugenis wrote:
> >
> > > This is great! Wrap.sh is definitely a better approach for 99% of users. Why are you saying that it needs an eng dev build though? I thought the idea behind wrap.sh is that it works on regular user devices, as long as the app has DEBUGGABLE in the manifest.
> >
> >
> > It actually doesn't need to be an eng or dev build.  I'm saying it needs root (setenforce 0 / setenforce 1 are the keys).  If you have root, either through su or through adb root, then the wrap method will work.
>
>
> I see. That's still bad, we'd like ASan to work on non-rooted devices. Do you know why setenforce 0 is necessary?


completely agreed.  I'd much prefer to not have to root.
See here for mystery reasoning of why (not a Google employee so not so easy for me to find out what the bugs are behind the scenes):
https://issuetracker.google.com/issues/63766481

It looks like it's at least a known issue.  I've been told by other google employees that there's a plan to address this in the emulator in future revisions by having multiple zygote processes.


https://reviews.llvm.org/D31695