[llvm] r309443 - [libFuzzer] improve support for inline-8bit-counters (make it more correct and faster)

[Kostya Serebryany via llvm-commits]

Author: kcc
Date: Fri Jul 28 15:00:56 2017
New Revision: 309443

URL: http://llvm.org/viewvc/llvm-project?rev=309443&view=rev
Log:
[libFuzzer] improve support for inline-8bit-counters (make it more correct and faster)

Modified:
    llvm/trunk/lib/Fuzzer/FuzzerTracePC.cpp
    llvm/trunk/lib/Fuzzer/FuzzerTracePC.h
    llvm/trunk/lib/Fuzzer/test/fuzzer-traces-hooks.test

Modified: llvm/trunk/lib/Fuzzer/FuzzerTracePC.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Fuzzer/FuzzerTracePC.cpp?rev=309443&r1=309442&r2=309443&view=diff
==============================================================================
--- llvm/trunk/lib/Fuzzer/FuzzerTracePC.cpp (original)
+++ llvm/trunk/lib/Fuzzer/FuzzerTracePC.cpp Fri Jul 28 15:00:56 2017
@@ -309,6 +309,14 @@ static size_t InternalStrnlen2(const cha
   return Len;
 }
 
+void TracePC::ClearInlineCounters() {
+  for (size_t i = 0; i < NumModulesWithInline8bitCounters; i++) {
+    uint8_t *Beg = ModuleCounters[i].Start;
+    size_t Size = ModuleCounters[i].Stop - Beg;
+    memset(Beg, 0, Size);
+  }
+}
+
 } // namespace fuzzer
 
 extern "C" {
@@ -345,6 +353,10 @@ void __sanitizer_cov_8bit_counters_init(
 }
 
 ATTRIBUTE_INTERFACE
+void __sanitizer_cov_pcs_init(const uint8_t *pcs_beg, const uint8_t *pcs_end) {
+}
+
+ATTRIBUTE_INTERFACE
 ATTRIBUTE_NO_SANITIZE_ALL
 void __sanitizer_cov_trace_pc_indir(uintptr_t Callee) {
   uintptr_t PC = reinterpret_cast<uintptr_t>(__builtin_return_address(0));

Modified: llvm/trunk/lib/Fuzzer/FuzzerTracePC.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Fuzzer/FuzzerTracePC.h?rev=309443&r1=309442&r2=309443&view=diff
==============================================================================
--- llvm/trunk/lib/Fuzzer/FuzzerTracePC.h (original)
+++ llvm/trunk/lib/Fuzzer/FuzzerTracePC.h Fri Jul 28 15:00:56 2017
@@ -87,8 +87,11 @@ class TracePC {
     ValueProfileMap.Reset();
     memset(Counters(), 0, GetNumPCs());
     ClearExtraCounters();
+    ClearInlineCounters();
   }
 
+  void ClearInlineCounters();
+
   void UpdateFeatureSet(size_t CurrentElementIdx, size_t CurrentElementSize);
   void PrintFeatureSet();
 
@@ -201,8 +204,11 @@ void TracePC::CollectFeatures(Callback H
   };
 
   size_t FirstFeature = 0;
-  ForEachNonZeroByte(Counters, Counters + N, FirstFeature, Handle8bitCounter);
-  FirstFeature += N * 8;
+  if (!NumInline8bitCounters) {
+    ForEachNonZeroByte(Counters, Counters + N, FirstFeature, Handle8bitCounter);
+    FirstFeature += N * 8;
+  }
+
   for (size_t i = 0; i < NumModulesWithInline8bitCounters; i++) {
     ForEachNonZeroByte(ModuleCounters[i].Start, ModuleCounters[i].Stop,
                        FirstFeature, Handle8bitCounter);

Modified: llvm/trunk/lib/Fuzzer/test/fuzzer-traces-hooks.test
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Fuzzer/test/fuzzer-traces-hooks.test?rev=309443&r1=309442&r2=309443&view=diff
==============================================================================
--- llvm/trunk/lib/Fuzzer/test/fuzzer-traces-hooks.test (original)
+++ llvm/trunk/lib/Fuzzer/test/fuzzer-traces-hooks.test Fri Jul 28 15:00:56 2017
@@ -3,7 +3,7 @@
 UNSUPPORTED: windows
 CHECK: BINGO
 
-RUN: not LLVMFuzzer-MemcmpTest               -seed=1 -runs=2000000   2>&1 | FileCheck %s
+RUN: not LLVMFuzzer-MemcmpTest               -seed=1 -runs=10000000   2>&1 | FileCheck %s
 RUN: not LLVMFuzzer-StrncmpTest              -seed=1 -runs=2000000   2>&1 | FileCheck %s
 RUN: not LLVMFuzzer-StrcmpTest               -seed=1 -runs=2000000   2>&1 | FileCheck %s
 RUN: not LLVMFuzzer-StrstrTest               -seed=1 -runs=2000000   2>&1 | FileCheck %s