[PATCH] D31695: Windows asan_device_setup.bat port of linux shell script

[Evgenii Stepanov via Phabricator via llvm-commits]

eugenis added inline comments.


================
Comment at: asan_device_setup.py:1
+#! /usr/bin/env monkeyrunner
+# ===- lib/asan/scripts/asan_device_setup -----------------------------------===#
----------------
there is no "monkeyrunner" in linux


================
Comment at: asan_device_setup.py:56
+        output, error = subprocess.Popen(
+                        cmd, universal_newlines=True,
+                        stdout=subprocess.PIPE, stderr=subprocess.PIPE).communicate()
----------------
This needs either shell=True or the command as an array of strings.


================
Comment at: asan_device_setup.py:379
+        outFile.write("#!/system/bin/sh-from-zygote\n")
+        outFile.write("ASAN_OPTIONS=" + self.ASAN_OPTIONS + "\n")
+        outFile.write("ASAN_ACTIVATION_OPTIONS=include_if_exists=/data/local/tmp/asan.options.%b\n")
----------------
This line needs to end with " \", or start with "export ", otherwise the environment variables are not passed to the exec'ed program.


https://reviews.llvm.org/D31695