[PATCH] D35979: [X86] Fix a crash in FEntryInserter Pass.

Manoj Gupta via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 28 12:00:03 PDT 2017


manojgupta added a comment.

From: David Blaikie <dblaikie at gmail.com> Date: Fri, Jul 28, 2017 at 11:38 AM

- The call to fentry is unconditionally added to the beginning of function.

& the other instruction may not be in the entry block?

- Should the call use the same debug location of the previous instruction if present?

No - it'll probably get that location anyway, later on/at code generation time, but you shouldn't add it to the instruction itself if it doesn't have any reason to be related/at that location.

- Dave


https://reviews.llvm.org/D35979





More information about the llvm-commits mailing list