[PATCH] D36002: AMDGPU: Initial implementation of calls

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: lib/Target/AMDGPU/SIFrameLowering.cpp:605
+      .addReg(SPReg)
+      .addImm(Amount * ST.getWavefrontSize());
+  } else if (CalleePopAmount != 0) {
----------------
arsenm wrote:
> rampitec wrote:
> > Which memory is used? I thought it is scratch, in which case it shall be already implicitly multiplied by the wavefront size.
> This is used by the scalar load/stores. The implicit multiply by the wave size applies to the VGPR and immediate offset, not the SGPR offset. Any operations on the SGPR offsets, which the SP/FP are need to be scaled.
This is used by the buffer load/stores. The implicit multiply by the wave size applies to the VGPR and immediate offset, not the SGPR offset. Any operations on the SGPR offsets, which the SP/FP are need to be scaled.



https://reviews.llvm.org/D36002