[LNT] r309413 - Do not create a MachineID, ParametersData index

Matthias Braun via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 28 11:02:45 PDT 2017


Author: matze
Date: Fri Jul 28 11:02:45 2017
New Revision: 309413

URL: http://llvm.org/viewvc/llvm-project?rev=309413&view=rev
Log:
Do not create a MachineID, ParametersData index

mysql cannot index arbitrary length data and I doubt this index is
particularily helpful anyway, espcially after r309247.

Note that the machine name still has an index.

Modified:
    lnt/trunk/lnt/server/db/migrations/upgrade_0_to_1.py
    lnt/trunk/lnt/server/db/testsuitedb.py

Modified: lnt/trunk/lnt/server/db/migrations/upgrade_0_to_1.py
URL: http://llvm.org/viewvc/llvm-project/lnt/trunk/lnt/server/db/migrations/upgrade_0_to_1.py?rev=309413&r1=309412&r2=309413&view=diff
==============================================================================
--- lnt/trunk/lnt/server/db/migrations/upgrade_0_to_1.py (original)
+++ lnt/trunk/lnt/server/db/migrations/upgrade_0_to_1.py Fri Jul 28 11:02:45 2017
@@ -276,12 +276,6 @@ def get_base_for_testsuite(test_suite):
     sqlalchemy.schema.Index("ix_%s_Sample_RunID_TestID" % db_key_name,
                             Sample.run_id, Sample.test_id)
 
-    args = [Machine.name, Machine.parameters_data]
-    for item in test_suite.machine_fields:
-        args.append(item.column)
-    sqlalchemy.schema.Index("ix_%s_Machine_Unique" % db_key_name,
-                            *args, unique = True)
-
     return Base
 
 def initialize_testsuite(engine, session, name):

Modified: lnt/trunk/lnt/server/db/testsuitedb.py
URL: http://llvm.org/viewvc/llvm-project/lnt/trunk/lnt/server/db/testsuitedb.py?rev=309413&r1=309412&r2=309413&view=diff
==============================================================================
--- lnt/trunk/lnt/server/db/testsuitedb.py (original)
+++ lnt/trunk/lnt/server/db/testsuitedb.py Fri Jul 28 11:02:45 2017
@@ -729,13 +729,6 @@ class TestSuiteDB(object):
         sqlalchemy.schema.Index("ix_%s_Sample_RunID_TestID" % db_key_name,
                                 Sample.run_id, Sample.test_id)
 
-        # Create the index we use to ensure machine uniqueness.
-        args = [Machine.name, Machine.parameters_data]
-        for item in self.machine_fields:
-            args.append(item.column)
-        sqlalchemy.schema.Index("ix_%s_Machine_Unique" % db_key_name,
-                                *args, unique=True)
-
         # Add several shortcut aliases, similar to the ones on the v4db.
         self.session = self.v4db.session
         self.add = self.v4db.add




More information about the llvm-commits mailing list