[PATCH] D35951: Remove the obsolete "offset" parameter from @llvm.dbg.value

[Duncan P. N. Exon Smith via Phabricator via llvm-commits]

dexonsmith accepted this revision.
dexonsmith added a comment.
This revision is now accepted and ready to land.

In https://reviews.llvm.org/D35951#823626, @aprantl wrote:

> In https://reviews.llvm.org/D35951#823564, @dexonsmith wrote:
>
> > The code changes and test/Bitcode/upgrade-dbg-value.ll LGTM.
> >
> > I spot-checked the other testcases, and couldn't find any that had anything other than `i64 0`.  Is that expected?  Or can you point me at a non-trivial one?
>
>
> We have been phasing out any remaining use of the offset field and replaced it with DIExpressions. This is also why the upgrade merely strips any dbg.value intrinsics with nonzero offsets.    It's effectively dead code.


Got it.  LGTM!


Repository:
  rL LLVM

https://reviews.llvm.org/D35951