[PATCH] D30200: [SLP] Fix for PR31880: shuffle and vectorize repeated scalar ops on extracted elements

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added a comment.

One minor comment, but other than that it looks ok - @mkuper?



================
Comment at: lib/Transforms/Vectorize/SLPVectorizer.cpp:219
+    unsigned IntIdx = Idx->getValue().getZExtValue();
+    if (IntIdx >= Size)
+      continue;
----------------
You could merge this and the isNegative test above into a single bounds test by using:
```
if (Idx->getValue().uge(Size))
      continue;
unsigned IntIdx = Idx->getValue().getZExtValue();
```


https://reviews.llvm.org/D30200