[PATCH] D35742: [Driver] Register effective triple before get arm float abi.

[Peter Smith via Phabricator via llvm-commits]

peter.smith added a comment.

The change looks like an improvement to me. I've got some comments/suggestions although I don't have any strong opinions here.

- It isn't obvious from the context of Driver.cpp why ComputeEffectiveTriple() needs to be called. After a bit of searching I found the call to getArchNameForCompilerRTLib that contained the call to getARMFloatABI. Is is worth moving the call to ComputeEffectiveTriple just before the call to getARMFloatABI()?
- It would be good to add some tests for some more targets such as --target=arm-linux-gnueabihf and --target=arm-linux-gnueabi -mfloat-abi=hard


https://reviews.llvm.org/D35742