[PATCH] D35981: Migrate PGOMemOptSizeOpt to use new OptimizationRemarkEmitter Pass

[Sam Elliott via Phabricator via llvm-commits]

lenary added a reviewer: anemet.
lenary added a comment.

Two quick notes for feedback, I shall get started on working on a test.



================
Comment at: lib/Transforms/Instrumentation/PGOMemOPSizeOpt.cpp:30
 #include "llvm/IR/IRBuilder.h"
+#include "llvm/IR/InstVisitor.h"
 #include "llvm/IR/InstrTypes.h"
----------------
This change was added by `git clang-format`, probably incorrectly. 


================
Comment at: lib/Transforms/Instrumentation/PGOMemOPSizeOpt.cpp:384
+    using namespace ore;
+    ORE.emit(OptimizationRemark(DEBUG_TYPE, "memopt-opt", MI)
+             << "optimized " << getMIName(MI) << " with count "
----------------
Not sure this is the right pair of names for this remark, maybe I should use `getMIName(MI)` (which returns "memset"/"memcpy"/"memmove"/"unknown") for the second string as well?


https://reviews.llvm.org/D35981