[PATCH] D35979: [X86] Fix a crash in FEntryInserter Pass.

[Davide Italiano via Phabricator via llvm-commits]

davide added a comment.

Nice! What's the status of Linux 4.4 + clang?



================
Comment at: lib/CodeGen/FEntryInserter.cpp:46
   auto *TII = MF.getSubtarget().getInstrInfo();
-  BuildMI(FirstMBB, FirstMI, FirstMI.getDebugLoc(),
+  BuildMI(FirstMBB, FirstMBB.begin(), DebugLoc(),
           TII->get(TargetOpcode::FENTRY_CALL));
----------------
If the first BB is not empty, why you're not still passing `FirstMI.getDebugLoc()?


================
Comment at: test/CodeGen/X86/fentry-insertion.ll:15
 
-attributes #0 = { "fentry-call"="true" }
+; Function Attrs: inlinehint minsize noredzone nounwind optsize sspstrong
+define void @test2() #1 {
----------------
This comment is not needed.


================
Comment at: test/CodeGen/X86/fentry-insertion.ll:29
+
+; Function Attrs: minsize noredzone optsize
+declare void @address_taken(i64, i32) local_unnamed_addr
----------------
Ditto.


https://reviews.llvm.org/D35979