[PATCH] D35966: Changing the default MaxNumPromotions from 2 to 3.

Dehao Chen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 27 16:39:21 PDT 2017


danielcdh created this revision.
Herald added a subscriber: sanjoy.

In performance tuning, we see performance benefits when enlarge the maximum num promotion targets to 3. This is safe as soon as we have total percentage threshold properly setup (https://reviews.llvm.org/D35962)


https://reviews.llvm.org/D35966

Files:
  lib/Analysis/IndirectCallPromotionAnalysis.cpp


Index: lib/Analysis/IndirectCallPromotionAnalysis.cpp
===================================================================
--- lib/Analysis/IndirectCallPromotionAnalysis.cpp
+++ lib/Analysis/IndirectCallPromotionAnalysis.cpp
@@ -50,7 +50,7 @@
 // Set the maximum number of targets to promote for a single indirect-call
 // callsite.
 static cl::opt<unsigned>
-    MaxNumPromotions("icp-max-prom", cl::init(2), cl::Hidden, cl::ZeroOrMore,
+    MaxNumPromotions("icp-max-prom", cl::init(3), cl::Hidden, cl::ZeroOrMore,
                      cl::desc("Max number of promotions for a single indirect "
                               "call callsite"));
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D35966.108549.patch
Type: text/x-patch
Size: 649 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170727/0d75447a/attachment.bin>


More information about the llvm-commits mailing list