[PATCH] D35960: [MachineOutliner] Cleanup: move findCandidates out of suffix tree

Jessica Paquette via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 27 16:11:39 PDT 2017


paquette marked an inline comment as done.
paquette added a comment.

In https://reviews.llvm.org/D35960#823330, @MatzeB wrote:

> In https://reviews.llvm.org/D35960#823324, @paquette wrote:
>
> > Even better: put findCandidates actually *inside* the MachineOutliner class for consistency.
>
>
> Still LGTM. And if it's just moving code around inside a file you authored, just do it without phabricator review. Post-commit review is fine.


Awesome, thanks!


https://reviews.llvm.org/D35960





More information about the llvm-commits mailing list