[PATCH] D30913: [NFC] Feature generic options to setup start/stop-after/before

Matthias Braun via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 27 15:02:00 PDT 2017


MatzeB added a comment.

Looks like whatever I wrote went missing here it is again:



================
Comment at: include/llvm/Target/TargetMachine.h:228-231
+  virtual bool addPassesToEmitFile(PassManagerBase &, raw_pwrite_stream &,
+                                   CodeGenFileType,
+                                   bool /*DisableVerify*/ = true,
+                                   MachineModuleInfo **MMI = nullptr) {
----------------
I wonder if instead of setting an external `MachineModuleInfo **MMI` you could instead use whatever the user passes in and make this a `MachineModuleInfo *MMI`.


https://reviews.llvm.org/D30913





More information about the llvm-commits mailing list