[PATCH] D35865: [asan] Fuchsia port

[Vitaly Buka via Phabricator via llvm-commits]

vitalybuka added a reviewer: vitalybuka.
vitalybuka added inline comments.


================
Comment at: lib/asan/asan_interceptors.h:22
 
+#if !SANITIZER_FUCHSIA
+
----------------
I assume you disable entire things instead of particular interceptors, like other platforms, because Fuchsia does not need interceptors?

Could you please note that in the code.


================
Comment at: lib/asan/asan_rtl.cc:89
 
+#if !ASAN_PREALLOCATED_SHADOW
 // ---------------------- mmap -------------------- {{{1
----------------
Why not just SANITIZER_FUCHSIA


================
Comment at: lib/asan/asan_rtl.cc:342
 
+#if !ASAN_PREALLOCATED_SHADOW
 static void ProtectGap(uptr addr, uptr size) {
----------------
Maybe better to move some stuff into 
asan_rtl_no_fuchsia.cc (as separate CL)
and put new stuff into asan_rtl_fuchsia.cc?

Same for other files


================
Comment at: lib/asan/asan_thread.cc:234
+    // because the system itself uses an ASan-aware allocator for that.
+    CHECK(SANITIZER_FUCHSIA);
+    DCHECK_NE(GetCurrentThread(), this);
----------------
Could you please move this into fuchsia version of AsanThread::SetThreadStackAndTls()


Repository:
  rL LLVM

https://reviews.llvm.org/D35865