[PATCH] D29402: [SLP] Initial rework for min/max horizontal reduction vectorization, NFC.

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 27 08:31:12 PDT 2017


RKSimon added a comment.

There's still a lot going on in this patch but it looks alright to me (I noticed one minor).

Does anyone have any further comments?



================
Comment at: lib/Transforms/Vectorize/SLPVectorizer.cpp:4337
+
+  public:
+    explicit OperationData() = default;
----------------
If OperationData is a struct then this public can go?


https://reviews.llvm.org/D29402





More information about the llvm-commits mailing list