[PATCH] D35840: All libcalls should be considered to be GC-leaf functions.

[Anna Thomas via Phabricator via llvm-commits]

anna accepted this revision.
anna added a comment.
This revision is now accepted and ready to land.

This change looks good to me. However, I would suggest separating out the `PlaceSafepoints` (and it's testcase) change from the `RewriteStatepointsForGC` change. We don't use placeSafepoint anymore, so we should perhaps just deprecate it upstream, instead of fixing it. 
@reames: What do you suggest?



================
Comment at: lib/Transforms/Utils/Local.cpp:1850
 
+  // Lib calls can be materialized by some passes, and won't be
+  // marked as 'gc-leaf-function.' All available Libcalls are
----------------
Please state that libcalls can be materialized by RS4GC, there's no other passes right? (frankly, the placeSafepoints.cpp is deprecated).



https://reviews.llvm.org/D35840