[PATCH] D35789: [XRay][compiler-rt] Do not print the warning when the binary is not XRay instrumented.

Dean Michael Berris via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jul 27 04:44:34 PDT 2017


dberris added a comment.

In https://reviews.llvm.org/D35789#822349, @dblaikie wrote:

> In https://reviews.llvm.org/D35789#822323, @dberris wrote:
>
> > @dblaikie -- Added the test, and in the process learned that we haven't been building/running the unit tests because of some configuration problems. I've added the required changes here too.
>
>
> I'm guessing a bunch of the changes in here are fixes for tests that were broken but never running? Probably best to separate out the "make the tests run (& make them pass)" from the rest of this and commit it ahead of the rest. In case the functionality added has issues, needs to be reverted or dealt with in other ways, etc.


Yes, although it turns out that the unit tests were also printing the error I was fixing too. :/

I'll work a little bit more to see whether there's a clean way to introduce just the test for this change and the requisite changes to the lit configs.

Thanks!


https://reviews.llvm.org/D35789





More information about the llvm-commits mailing list