[PATCH] D35354: [X86][LLVM][TD] Arranging Atom family in an inheritance ratio

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: lib/Target/X86/X86.td:415
   FeatureAES,
-  FeatureSlowDivide64,
   FeatureCallRegIndirect,
   FeaturePRFCHW,
----------------
Why is CallRegIndirect in BonnellProc and AtomPlusFeatures? Should it be in AtomFeatures instead? Or should each CPU list is separately?


================
Comment at: lib/Target/X86/X86.td:417
   FeaturePRFCHW,
   FeatureSlowLEA,
   FeatureSlowIncDec,
----------------
I don't think the "Slow" features should be part of AtomPlusFeatures. While its great for sharing between Silvermont and Goldmont. It makes AtomPlusFeatures hard to inherit from for the processor after Goldmont if it changes any of those things.


https://reviews.llvm.org/D35354