[PATCH] D35929: [ICP] Migrate to OptimizationRemarkEmitter

[Adam Nemet via Phabricator via llvm-commits]

anemet created this revision.
Herald added subscribers: eraman, fhahn, mehdi_amini.

This is a module pass so for the old PM, we can't use ORE, the function
analysis pass.  Instead ORE is created on the fly.

A few notes:

- isPromotionLegal is folded in the caller since we want to emit the Function

in the remark but we can only do that if the symbol table look-up succeeded.

- There was good test coverage for remarks in this pass.

- promoteIndirectCall uses ORE conditionally since it's also used from

SampleProfile which does not use ORE yet.

Fixes PR33792.


https://reviews.llvm.org/D35929

Files:
  include/llvm/Transforms/Instrumentation.h
  lib/Transforms/Instrumentation/IndirectCallPromotion.cpp
  test/Other/new-pm-lto-defaults.ll
  test/Other/new-pm-thinlto-defaults.ll
  test/Transforms/PGOProfile/icp_mismatch_msg.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D35929.108415.patch
Type: text/x-patch
Size: 13071 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170727/3f6172dd/attachment.bin>