[PATCH] D35871: [PDB] Write public symbol records and the publics hash table

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 26 18:04:11 PDT 2017


ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lld/COFF/SymbolTable.h:112
+    for (auto &Pair : Symtab)
+      Callback(Pair.first.val(), Pair.second);
+  }
----------------
Since you are not using `Pair.first.val()` at least at the moment, pass only `Pair.second`.


https://reviews.llvm.org/D35871





More information about the llvm-commits mailing list