[PATCH] D35901: [DAG] Improve candidate pruning in store merge failure case. NFC.

Noel Grandin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jul 26 13:03:46 PDT 2017


grandinj added inline comments.


================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:12853
+        // and of correct shape. While there is no mergable sequence
+        // from the beggining one may start later in the sequence. The
+        // only reason a merge of size N could have failed where
----------------
beggining -> beginning


================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:12855
+        // only reason a merge of size N could have failed where
+        // another of the same size would not have does not is if the
+        // alignment has improved or we've dropped a non-zero
----------------
another of the same size would not have does not is if the
->
another of the same size would not have,  is if the


================
Comment at: lib/CodeGen/SelectionDAG/DAGCombiner.cpp:12927
+        // only reason a merge of size N could have failed where
+        // another of the same size would not have does not is if the
+        // alignment has improved. Drop as many candidates as we can here.
----------------
ditto x 2


https://reviews.llvm.org/D35901





More information about the llvm-commits mailing list