[PATCH] D35909: [lit] Port googletest lit tests to Windows

[Reid Kleckner via Phabricator via llvm-commits]

rnk created this revision.

The technique of directly calling subprocess.Popen on a python script
doesn't work on Windows. The executable path of the command must refer
to a valid win32 executable.

Instead, rename all the python scripts masquerading as gtest executables
to have .py extensions, so we can easily detect then and call the python
executable for them. Do this on Linux as well as Windows for
consistency.

Fixes PR33933


https://reviews.llvm.org/D35909

Files:
  llvm/utils/lit/lit/formats/googletest.py
  llvm/utils/lit/tests/Inputs/googletest-format/DummySubDir/OneTest
  llvm/utils/lit/tests/Inputs/googletest-format/DummySubDir/OneTest.py
  llvm/utils/lit/tests/Inputs/googletest-timeout/DummySubDir/OneTest
  llvm/utils/lit/tests/Inputs/googletest-timeout/DummySubDir/OneTest.py
  llvm/utils/lit/tests/Inputs/googletest-upstream-format/DummySubDir/OneTest
  llvm/utils/lit/tests/Inputs/googletest-upstream-format/DummySubDir/OneTest.py
  llvm/utils/lit/tests/googletest-format.py
  llvm/utils/lit/tests/googletest-timeout.py
  llvm/utils/lit/tests/googletest-upstream-format.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D35909.108340.patch
Type: text/x-patch
Size: 10852 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170726/d7e53499/attachment.bin>