[PATCH] D35878: [lit] Fix type error for parallelism groups

[Reid Kleckner via Phabricator via llvm-commits]

rnk added inline comments.


================
Comment at: utils/lit/lit/LitConfig.py:28
                  maxFailures = None,
-                 parallelism_groups = [],
+                 parallelism_groups = {},
                  echo_all_commands = False):
----------------
Isn't this one of the classic python traps? If self.parallelism_groups is modified, it will modify the default argument used by all LitConfig objects. The usual workaround is to set this to None and test for it below or elsewhere.


https://reviews.llvm.org/D35878