[PATCH] D35793: [ELF] - Change way how we handle --noinhibit-exec

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: ELF/Driver.cpp:646-648
   Config->NoGnuUnique = Args.hasArg(OPT_no_gnu_unique);
+  Config->NoinhibitExec = Args.hasArg(OPT_noinhibit_exec);
   Config->NoUndefinedVersion = Args.hasArg(OPT_no_undefined_version);
----------------
ruiu wrote:
> Sort
> 
Done (I hope I got sorting rule correctly now). 
But isn't it easier/more usefu(for search) just to ignore character upper/lower cases
when sorting this list ?

Not sure it makes sense to have current:
```
Config->NoGnuUnique = Args.hasArg(OPT_no_gnu_unique);
Config->NoUndefinedVersion = Args.hasArg(OPT_no_undefined_version);
Config->NoinhibitExec = Args.hasArg(OPT_noinhibit_exec);
Config->Nostdlib = Args.hasArg(OPT_nostdlib);
```

instead of straightforward:
```
Config->NoGnuUnique = Args.hasArg(OPT_no_gnu_unique);
Config->NoinhibitExec = Args.hasArg(OPT_noinhibit_exec);
Config->Nostdlib = Args.hasArg(OPT_nostdlib);
Config->NoUndefinedVersion = Args.hasArg(OPT_no_undefined_version);
```


Repository:
  rL LLVM

https://reviews.llvm.org/D35793