[PATCH] D35744: Make new PM honor -fdebug-info-for-profiling

[Dehao Chen via Phabricator via llvm-commits]

danielcdh added inline comments.


================
Comment at: include/llvm/Passes/PassBuilder.h:35
   std::string SampleProfileFile = "";
+  bool SampleProfileGen = false;
   bool RunProfileGen = false;
----------------
chandlerc wrote:
> Calling this profile generation seems odd.
> 
> I would call this more along the lines of supporting sample PGO *at all* (even if not using a specific profile file), and then set it to true if a file is provided (which will become more obvious with a constructor when rebased on your other patch).
> 
> Then the condition below seems simpler.
Updated the patch to change the name, also added tests.

Not sure what name to use at the opt driver, any suggestions?

Thanks,
Dehao


https://reviews.llvm.org/D35744