[PATCH] D35877: Revert "[lit] Remove dead code not referenced in the LLVM SVN repo."

Brian Gesiak via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 25 21:16:28 PDT 2017


modocache created this revision.

This reverts https://reviews.llvm.org/rL306623, which removed `FileBasedTest`, an abstract base class,
but did not also remove the usages of that class in the lit unit tests.
The revert fixes four test failures in the lit unit test suite.

Test plan:
As per the instructions in `utils/lit/README.txt`, run the lit unit
test suite:

  utils/lit/lit.py \
      --path /path/to/your/llvm/build/bin \
      utils/lit/tests

Verify that the following tests fail before applying this patch, and
pass once the patch is applied:

  lit :: test-data.py
  lit :: test-output.py
  lit :: xunit-output.py

In addition, run `check-llvm` to make sure the existing LLVM test suite
executes normally.


https://reviews.llvm.org/D35877

Files:
  utils/lit/lit/formats/__init__.py
  utils/lit/lit/formats/base.py
  utils/lit/lit/formats/shtest.py

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D35877.108209.patch
Type: text/x-patch
Size: 8563 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170726/500286a7/attachment.bin>


More information about the llvm-commits mailing list