[PATCH] D35868: Detemplate part of SymbolTable

Rafael Avila de Espindola via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 25 19:28:35 PDT 2017


Rui Ueyama via Phabricator <reviews at reviews.llvm.org> writes:

> ruiu added a comment.
>
> I think we can detemplate this class without creating a class hierarchy. Most part of the class does not use ELFT, so I think we can template member functions and then detemplate the class.


The problem with that are the members:

  std::vector<ObjectFile<ELFT> *> ObjectFiles;
  std::vector<SharedFile<ELFT> *> SharedFiles;

Cheers,
Rafael


More information about the llvm-commits mailing list