[llvm] r309056 - [gold] Enable function-sections by default.

[Davide Italiano via llvm-commits]

Author: davide
Date: Tue Jul 25 16:32:50 2017
New Revision: 309056

URL: http://llvm.org/viewvc/llvm-project?rev=309056&view=rev
Log:
[gold] Enable function-sections by default.

This is needed, among others, to respect --section-ordering-file
with LTO. I'll follow up with a similar change for data sections.

I hope every version of gold available on the bots has support for
--section-ordering file.

Added:
    llvm/trunk/test/tools/gold/X86/multiple-sections.ll
Modified:
    llvm/trunk/tools/gold/gold-plugin.cpp

Added: llvm/trunk/test/tools/gold/X86/multiple-sections.ll
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/test/tools/gold/X86/multiple-sections.ll?rev=309056&view=auto
==============================================================================
--- llvm/trunk/test/tools/gold/X86/multiple-sections.ll (added)
+++ llvm/trunk/test/tools/gold/X86/multiple-sections.ll Tue Jul 25 16:32:50 2017
@@ -0,0 +1,40 @@
+; RUN: echo ".text.tin" > %t_order_lto.txt
+; RUN: echo ".text._start" >> %t_order_lto.txt
+; RUN: echo ".text.pat" >> %t_order_lto.txt
+; RUN: llvm-as %s -o %t.o
+; RUN: %gold -plugin %llvmshlibdir/LLVMgold.so \
+; RUN:     -m elf_x86_64 -o %t.exe %t.o \
+; RUN:     --section-ordering-file=%t_order_lto.txt
+; RUN: llvm-readobj -elf-output-style=GNU -t %t.exe | FileCheck %s
+
+; Check that the order of the sections is tin -> _start -> pat.
+
+; CHECK: Symbol table '.symtab' contains 8 entries:
+; CHECK-NEXT:    Num:    Value          Size Type    Bind   Vis      Ndx Name
+; CHECK-NEXT:      0: 0000000000000000     0 NOTYPE  LOCAL  DEFAULT  UND
+; CHECK-NEXT:      1: 0000000000000000     0 FILE    LOCAL  DEFAULT  ABS ld-temp.o
+; CHECK-NEXT:      2: 00000000004000d0     1 FUNC    LOCAL  DEFAULT    1 pat
+; CHECK-NEXT:      3: 00000000004000b0     1 FUNC    LOCAL  DEFAULT    1 tin
+; CHECK-NEXT:      4: 0000000000000000     0 NOTYPE  GLOBAL DEFAULT  ABS _end
+; CHECK-NEXT:      5: 0000000000000000     0 NOTYPE  GLOBAL DEFAULT  ABS __bss_start
+; CHECK-NEXT:      6: 0000000000000000     0 NOTYPE  GLOBAL DEFAULT  ABS _edata
+; CHECK-NEXT:      7: 00000000004000c0    15 FUNC    GLOBAL DEFAULT    1 _start
+
+target datalayout = "e-m:e-i64:64-f80:128-n8:16:32:64-S128"
+target triple = "x86_64-unknown-linux-gnu"
+
+define void @pat() #0 {
+  ret void
+}
+
+define void @tin() #0 {
+  ret void
+}
+
+define i32 @_start() {
+  call void @pat()
+  call void @tin()
+  ret i32 0
+}
+
+attributes #0 = { noinline optnone }

Modified: llvm/trunk/tools/gold/gold-plugin.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/tools/gold/gold-plugin.cpp?rev=309056&r1=309055&r2=309056&view=diff
==============================================================================
--- llvm/trunk/tools/gold/gold-plugin.cpp (original)
+++ llvm/trunk/tools/gold/gold-plugin.cpp Tue Jul 25 16:32:50 2017
@@ -750,6 +750,9 @@ static std::unique_ptr<LTO> createLTO()
   // FIXME: Check the gold version or add a new option to enable them.
   Conf.Options.RelaxELFRelocations = false;
 
+  // Enable function sections by default.
+  Conf.Options.FunctionSections = true;
+
   Conf.MAttrs = MAttrs;
   Conf.RelocModel = RelocationModel;
   Conf.CGOptLevel = getCGOptLevel();