[PATCH] D35853: [DWARF] Generalized verification of .apple_names accelerator table to be applicable to any acceleration table. Added verification for .apple_types, .apple_namespaces and .apple_objc sections.

[Adrian Prantl via Phabricator via llvm-commits]

aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.

Two minor nitpicks, but otherwise LGTM, thanks!



================
Comment at: include/llvm/DebugInfo/DWARF/DWARFVerifier.h:175
+  /// \returns true if the existing accelerator tables verify successfully,
+  /// false otherwise.
+  bool handleAccelTables();
----------------
aprantl wrote:
> ... existing *Apple-style* accelerator tables ...
> DWARF v5 accelerator tables are not yet supported.
Would you mind removing the `*`s again? I meant to use them as <insert new text here>-marker.

Sorry :-)


================
Comment at: lib/DebugInfo/DWARF/DWARFVerifier.cpp:483
+  // Verify that the section is not too short.
+  // uint32_t Offset = 8;
+  if (!AccelTable.extract()) {
----------------
remove commented out line


https://reviews.llvm.org/D35853