[PATCH] D35753: llvm-mt: implement simple merging of manifests, not factoring namespaces.

[Eric Beckmann via Phabricator via llvm-commits]

ecbeckmann added inline comments.


================
Comment at: llvm/lib/Support/WindowsManifestMerger.cpp:19-20
 
+#define TO_XML_CHAR(X) reinterpret_cast<const unsigned char *>(X)
+#define FROM_XML_CHAR(X) reinterpret_cast<const char *>(X)
+
----------------
ruiu wrote:
> In C++ it is not a very good practice to use a C macro where you can avoid it. I'd probably keep the original reinterpret_casts, but if you like this, I think I'm fine with it.
I really prefer this, having the entire reinterpret_cast written out every time clutters the code IMO


https://reviews.llvm.org/D35753