[PATCH] D35377: [CMAKE] Speedup developer builds when passing LLVM_APPEND_VC_REV = OFF

[David Blaikie via llvm-commits]

On Tue, Jul 25, 2017 at 7:57 AM don hinton <hintonda at gmail.com> wrote:

> On Mon, Jul 24, 2017 at 9:54 AM, Rafael Avila de Espindola <
> rafael.espindola at gmail.com> wrote:
>
>> LGTM
>>
>
> Is it okay to go ahead and commit or should I wait untill the revision is
> accepted?
>

Phabricator use is optional, the mailing list is the authoritative record -
"LGTM" is generally considered to be approval.

So: Yes, you should go ahead and commit :) (& keep the Differential
Revision in the commit message, that'll auto-close/update the Phab review)


>
>
>>
>> don hinton via Phabricator <reviews at reviews.llvm.org> writes:
>>
>> > hintonda added a comment.
>> >
>> > ping...
>> >
>> >
>> > https://reviews.llvm.org/D35377
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170725/53326051/attachment.html>