[PATCH] D35625: Removal of microMIPS64R6

[Simon Dardis via Phabricator via llvm-commits]

sdardis added a subscriber: llvm-commits.
sdardis added a comment.

Some minor comments.



================
Comment at: CodeGen/Mips/tailcall/tailcall.ll:31
 ; RUN:     -mattr=+micromips -mips-tail-calls=1 < %s | FileCheck %s -check-prefixes=ALL,STATIC32
-; RUN: llc -march=mips64el -relocation-model=pic -mcpu=mips64r6 \
-; RUN:     -mattr=+micromips -mips-tail-calls=1 < %s | FileCheck %s -check-prefix=PIC64R6MM
-; RUN: llc -march=mips64el -relocation-model=static -mcpu=mips64r6 \
-; RUN:     -mattr=+micromips -mips-tail-calls=1 < %s | FileCheck %s -check-prefix=STATIC64
+
 
----------------
Spurious blank line.


================
Comment at: Target/Mips/MipsSubtarget.cpp:107
+  if (hasMips64r6() && InMicroMipsMode) {
+    report_fatal_error("Micromips is not supported in Mips64r6 revision");    
+  }
----------------
The error message should be "microMIPS64R6 is not supported".


================
Comment at: Target/Mips/MipsTargetMachine.cpp:181
+  if (CPU == "mips64r6" && HasMicroMipsAttr) {
+    errs() << "LLVM currently does not support mircomips for '" << CPU << "'.\n";
+    HasMicroMipsAttr = false;
----------------
mircomips -> microMIPS.


Repository:
  rL LLVM

https://reviews.llvm.org/D35625