[PATCH] D35830: [x86, CGP] reduce memcmp() expansion to 2 load pairs (PR33914)

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 25 03:46:16 PDT 2017


RKSimon created this revision.

https://reviews.llvm.org/D35067/https://reviews.llvm.org/rL308322 attempted to support up to 4 load pairs for memcmp inlining which resulted in some regressions for some optimized libc memcmp implementations (PR33914).

Until we can match these more optimal cases, this patch reduces the memcmp() expansion to a maximum of 2 load pairs (which matches what we do for -Os).

This patch should be considered for the 5.0.0 release branch as well


Repository:
  rL LLVM

https://reviews.llvm.org/D35830

Files:
  lib/Target/X86/X86ISelLowering.cpp
  test/CodeGen/X86/memcmp.ll
  test/Transforms/CodeGenPrepare/X86/memcmp.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D35830.108043.patch
Type: text/x-patch
Size: 84382 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170725/5faafa68/attachment-0001.bin>


More information about the llvm-commits mailing list