[PATCH] D35681: [globalisel][tablegen] Fuse the generated tables together.

[Diana Picus via Phabricator via llvm-commits]

rovka added inline comments.


================
Comment at: include/llvm/CodeGen/GlobalISel/InstructionSelectorImpl.h:251
         return false;
 
     case GIR_MutateOpcode: {
----------------
Shouldn't there be a break here?


================
Comment at: utils/TableGen/GlobalISelEmitter.cpp:57
+/// A unique identifier for a MatchTable label.
+static unsigned CurrentLabelID = 0;
 
----------------
Does this need to be tracked externally? Can't the MatchTable manage it now?


================
Comment at: utils/TableGen/GlobalISelEmitter.cpp:2498
+  Table.emitDeclaration(OS);
+  OS << "  State.MIs.resize(1);\n"
+     << "  if (executeMatchTable(*this, OutMIs, State, MatcherInfo, ";
----------------
This isn't necessary anymore.


https://reviews.llvm.org/D35681