[PATCH] D35774: [x86][inline-asm]Extend support for memory reference expression

[coby via Phabricator via llvm-commits]

coby added a comment.

// I would really prefer to see fewer rewrites and more pass through of inline assembly to MC//
As do I. What are you suggesting? Keep rewrites to the absolute necessary minimum?
Pepole do some funky stuff on MS-Inline-Asm, a large portion of it should be 'legalized' in order for the Assembler to be able to digest.
The other way around is to allow this nonsense in the Assembler as well.
Both options are bad, but I believe the latter is a bit more.

If it's of any comfort - have this 'new' rewrite is to be allowed - AOK_Imm/AOK_ImmPrefix/AOK_SizeDirective can be implemented as a special case of it (AOK_DotOperator should be cancelled).
Net effect will remain the same - but it'll be (possibly) less of a mess of code.


Repository:
  rL LLVM

https://reviews.llvm.org/D35774