[PATCH] D35476: [libOption] - Add flag allowing to print options aliases in help text.

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 25 00:37:43 PDT 2017


grimar added a comment.

In https://reviews.llvm.org/D35476#819118, @ruiu wrote:

> The new behavior is probably fine, but I don't think you needed to change the parameter name.


I changed newly introduced `ShowAliases` to `InferHelpText` because first one is not completelly correctly
reflects the action performed.

If we have `HelpTex`t specified for alias:
`def alias_version_V: Flag<["-"], "V">, Alias<version>, HelpText<"blah blah">;`
then regardless of `ShowAliases` flag value, this option will be shown. 
Because old logic prints all options with `HelpText` at first place (and I did not change it here).

Probably we can name it `ShowAllAliases` ? With description saying it will trigger rendering all
aliases regardless they have `HelpText` explicitly set or not.


https://reviews.llvm.org/D35476





More information about the llvm-commits mailing list