[PATCH] D35588: Remove --commit/--commit=1 flags/settings.

Tobias Grosser via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jul 25 00:09:11 PDT 2017


grosser added a comment.

Interesting. I wonder if one use case for this option was to submit (but not commit) a run and then just obtain a set of performance comparisons against the last submitted run. I think I have seen this pattern once, but I am not using it.

I personally won't be affected by the removal of this option, so I am fine with dropping it immediately. Now, a slightly less agressive approach would be to just switch it's default value, deprecate it and wait for a release or two to actually remove it.


Repository:
  rL LLVM

https://reviews.llvm.org/D35588





More information about the llvm-commits mailing list