[PATCH] D35567: [Sparc] invalid adjustments in TLS_LE/TLS_LDO relocations removed

[Rafael Avila de Espindola via llvm-commits]

Fedor Sergeev via Phabricator <reviews at reviews.llvm.org> writes:
> +! RUN: llvm-mc %s -arch=sparc -show-encoding | FileCheck %s --check-prefix=ASM
> +! RUN: llvm-mc %s -arch=sparcv9 -show-encoding | FileCheck %s --check-prefix=ASM
> +! RUN: llvm-mc %s -arch=sparc -filetype=obj | llvm-readobj -r | FileCheck %s --check-prefix=REL
> +! RUN: llvm-mc %s -arch=sparcv9 -filetype=obj | llvm-readobj -r | FileCheck %s --check-prefix=REL
> +! RUN: llvm-mc %s -arch=sparc -filetype=obj | llvm-objdump -r -d - | FileCheck %s --check-prefix=OBJDUMP
> +! RUN: llvm-mc %s -arch=sparcv9 -filetype=obj | llvm-objdump -r -d - | FileCheck %s --check-prefix=OBJDUMP
> +
> +	! REL: Arch: sparc
> +        ! REL: Relocations [
> +        ! REL: 0x{{[0-9,A-F]+}} R_SPARC_TLS_LE_HIX22 _ZL4Head 0x0
> +	! REL: 0x{{[0-9,A-F]+}} R_SPARC_TLS_LE_LOX10 _ZL4Head 0x0
> +	! REL: 0x{{[0-9,A-F]+}} R_SPARC_TLS_LDO_HIX22 _ZL4Head 0x0
> +	! REL: 0x{{[0-9,A-F]+}} R_SPARC_TLS_LDM_HI22  _ZL4Head 0x0
> +	! REL: 0x{{[0-9,A-F]+}} R_SPARC_TLS_LDM_LO10  _ZL4Head 0x0
> +	! REL: 0x{{[0-9,A-F]+}} R_SPARC_TLS_LDO_LOX10 _ZL4Head 0x0
> +        ! REL: ]


Just a nit, but the indentation looks funny. I normally see the comment
character (!,#,@) in the first column.

> +	! OBJDUMP: _ZTWL4Head:
> +_ZTWL4Head:

You can use a simpler name :-)

LGTM with the nits fixed.

Tt is reasonable from a MC perspective and you know a lot more about the
Sparc ABI.

Cheers,
Rafael