[PATCH] D35791: [COFF, ARM64] Fix symbol offsets in ADRP/ADD/LDR/STR relocations

[Rafael Avila de Espindola via llvm-commits]

Martin Storsjö via Phabricator <reviews at reviews.llvm.org> writes:
>    case AArch64::fixup_aarch64_pcrel_adrp_imm21:
> +    if (TheTriple.isOSBinFormatCOFF() && !IsResolved)
> +      return AdrImmBits(Value & 0x1fffffULL);

If IsResolved should always be false, plase assert.

>    case AArch64::fixup_aarch64_add_imm12:
>    case AArch64::fixup_aarch64_ldst_imm12_scale1:
> +    if (TheTriple.isOSBinFormatCOFF())
> +      Value &= 0xfff;

What about all the other cases? Do you also expect IsResolved to always
be false?

Cheers,
Rafael