[PATCH] D35753: llvm-mt: implement simple merging of manifests, not factoring namespaces.

[Eric Beckmann via Phabricator via llvm-commits]

ecbeckmann added inline comments.


================
Comment at: llvm/include/llvm/Support/WindowsManifestMerger.h:84
 
 #if LLVM_LIBXML2_ENABLED
+  XMLDocumentImpl CombinedDoc = nullptr;
----------------
ruiu wrote:
> Likewise, always define this variable and don't use it if libxml is not available.
Unfortunately this will cause the sanitizer to complain that "CombinedDoc is never used".


https://reviews.llvm.org/D35753