[PATCH] D35332: [GISel]: More flexibility while building I/FCmps with MachineIRBuilder

Daniel Sanders via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jul 24 05:25:50 PDT 2017

Previous message: [PATCH] D33838: [ARM] Create relocations for wide Thumb2 unconditional branches.
Next message: [PATCH] D35332: [GISel]: More flexibility while building I/FCmps with MachineIRBuilder
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

dsanders added a comment.

Hi Aditya,

The subject and summary needs to better explain what the change is doing. There should also be something that uses the new functions otherwise they'll be deleted as dead code at some point in the future.


Repository:
  rL LLVM

https://reviews.llvm.org/D35332

Previous message: [PATCH] D33838: [ARM] Create relocations for wide Thumb2 unconditional branches.
Next message: [PATCH] D35332: [GISel]: More flexibility while building I/FCmps with MachineIRBuilder
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

More information about the llvm-commits mailing list