[PATCH] D35179: [X86][AVX512] Add patterns for masked AVX512 floating point compare instructions that were missing.

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon accepted this revision.
RKSimon added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: test/CodeGen/X86/avx512vl-vec-masked-cmp.ll:6
+; Please update the test accordingly.
+
 define zeroext i32 @test_vpcmpeqb_v16i1_v32i1_mask(<2 x i64> %__a, <2 x i64> %__b) local_unnamed_addr {
----------------
aymanmus wrote:
> RKSimon wrote:
> > Please can you submit the new test cases with the current codegen and then update this patch to show the diffs? I updated the test file a while ago (after this patch was created) to show the mess that KNL (NoVLX) makes. You should be able to use update_llc_test_checks.py as well now.
> I think you misunderstood this patch. Sorry if that wasn't clear.
> The new patterns does not handle the KNL cases, but complete the set of patterns added in previous commit to floating point types also (masked versions of floating point were missing).
> The added test cases will crash with "Cannot Select" error without the new patterns.
Thanks for the explanation, I thought this was just a codegen quality issue, not a bug fix.


https://reviews.llvm.org/D35179