[PATCH] D35766: [COFF] ARM64 support for COFFImportFile

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jul 23 03:37:45 PDT 2017


mstorsjo added a comment.

In https://reviews.llvm.org/D35766#818234, @compnerd wrote:

> You should be able to generate an object file with the imgrel relocation.


That doesn't actually test this codepath, that's already handled within lib/Target/AArch64/MCTargetDesc/AArch64WinCOFFObjectWriter.cpp, where `VK_COFF_IMGREL32` is mapped to `COFF::IMAGE_REL_ARM64_ADDR32NB`. The only place where this `getImgRelRelocation` function is used is within COFFImportFile.cpp, in the `createImportDescriptor` function.


https://reviews.llvm.org/D35766





More information about the llvm-commits mailing list