[PATCH] D35702: [LTO][ThinLTO] Use the linker resolutions to mark global values as dso_local.

[Mehdi AMINI via Phabricator via llvm-commits]

mehdi_amini added inline comments.


================
Comment at: lib/Bitcode/Reader/BitcodeReader.cpp:876
   bool Live = (RawFlags & 0x2) || Version < 3;
-  return GlobalValueSummary::GVFlags(Linkage, NotEligibleToImport, Live);
+  bool Local = (RawFlags & 0x4);
+
----------------
inouehrs wrote:
> Do we need some version check (and some comments) for compatibility with old bc files? 
The default will be `0` for old .bc files, which translate to "not local", which should be conservatively OK I believe?

Ideally we would checking a bitcode file from the 5.0 branching point in the repo and test this behavior.


Repository:
  rL LLVM

https://reviews.llvm.org/D35702