[PATCH] D35165: [sanitizer] Support compiler-rt builtins

Petr Hosek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 21 17:15:25 PDT 2017


phosek added inline comments.


================
Comment at: CMakeLists.txt:97
 
+option(SANITIZER_USE_COMPILER_RT "Use compiler-rt instead of libgcc" OFF)
+
----------------
alekseyshl wrote:
> Maybe a bit more specific name and comment, SANITIZER_USE_COMPILER_RT_BUILTINS
I agree it's not be best name, but it's consistent with the name we use in other runtimes (libc++, libc++abi, libunwind) which will hopefully allow us to set `<runtime>_USE_COMPILER_RT=ON` reducing some of the boilerplate.


Repository:
  rL LLVM

https://reviews.llvm.org/D35165





More information about the llvm-commits mailing list