[PATCH] D34727: AMDGPU/SI: Don't fix a PHI under uniform branch in SIFixSGPRCopies only when sources and destination are all sgprs

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: test/CodeGen/AMDGPU/vgpr-to-sgpr-phi.ll:7-9
+define void @vgpr_to_sgpr_phi(i32* nocapture) local_unnamed_addr #0 {
+  br label %2
+
----------------
arsenm wrote:
> arsenm wrote:
> > Run instnamer on test. Also can be merged 
> It may be better to reformulate as a kernel for now, which will require a non-argument source for the VGPR
It can merge into one of the other test files for this pass


================
Comment at: test/CodeGen/AMDGPU/vgpr-to-sgpr-phi.ll:7
+; GCN: s_branch BB0_1
+define void @vgpr_to_sgpr_phi(i32* nocapture %arg) local_unnamed_addr #0 {
+bb:
----------------
Does it still reproduce if you make it a kernel?


https://reviews.llvm.org/D34727