[PATCH] D35733: [DWARF] Added verification check for die ranges. If highPC is an address, then it should be greater or equal to lowPC for each range.

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 21 15:30:31 PDT 2017


dblaikie added inline comments.


================
Comment at: lib/DebugInfo/DWARF/DWARFVerifier.cpp:218
+  for (auto Range : Die.getAddressRanges()) {
+    if (Range.LowPC > Range.HighPC) {
+      ++NumErrors;
----------------
Should this be >=? Or is it intentional that empty ranges are allowed to account for things like comdat functions being omitted by the linker & resolving the addresses to zero? (I forget exactly how those work)


https://reviews.llvm.org/D35733





More information about the llvm-commits mailing list