[PATCH] D35664: [SCEV] Limit max size of AddRecExpr during evolving

[Sanjoy Das via Phabricator via llvm-commits]

sanjoy accepted this revision.
sanjoy added a comment.
This revision is now accepted and ready to land.

Hi,

This change itself looks fine to me.  However, I'm getting a bit worried about the arbitrariness of thresholds we have now.  Can you figure out some way to get the histograms of these limits seen on a run (and perhaps run it over some benchmarks you have)?  That is, what are the values of `AddRec->getNumOperands() + OtherAddRec->getNumOperands() - 1` we actually see in a run?  We could record and report this dependent on a flag.


https://reviews.llvm.org/D35664