[PATCH] D35115: X86 Asm should produce error messages instead of assertions when it's possible

Andrew V. Tischenko via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jul 21 08:13:56 PDT 2017


avt77 updated this revision to Diff 107675.
avt77 retitled this revision from "Clang's assembler crashes if Scale in lea is negative (pr33661)" to "X86 Asm should produce error messages instead of assertions when it's possible".
avt77 added a comment.

This patch replaces assertions with normal diagnostic when it's possible. Now we see normal error messages instead of compiler crashes. It should close PR33861, PR33862 and PR33661. In addition the patch prepares tests for https://reviews.llvm.org/D35621.


https://reviews.llvm.org/D35115

Files:
  lib/Target/X86/AsmParser/X86AsmParser.cpp
  test/MC/X86/intel-syntax-invalid-scale.s
  test/MC/X86/intel-syntax.s
  test/MC/X86/intel-syntax2.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D35115.107675.patch
Type: text/x-patch
Size: 11204 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20170721/bc732c38/attachment.bin>


More information about the llvm-commits mailing list